feat(identity): add invite to Users service#609
Open
Sarath1018 wants to merge 2 commits into
Open
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| }); | ||
|
|
||
| it('should throw when the user ID is undefined', async () => { | ||
| const user = createUserWithMethods(createBasicUser({ id: undefined as any }), mockService); |
Contributor
There was a problem hiding this comment.
The as any cast is unnecessary. createBasicUser accepts Partial<RawUserGetResponse>, which makes id type string | undefined, so { id: undefined } is valid TypeScript without a cast. Same issue on line 69.
Convention: "No any type — use unknown if truly unknown, then validate."
Suggested change
| const user = createUserWithMethods(createBasicUser({ id: undefined as any }), mockService); | |
| const user = createUserWithMethods(createBasicUser({ id: undefined }), mockService); |
Contributor
Review summaryNew finding posted this run:
Everything else checked out — transform pipeline, endpoint routing, type naming, pagination absence, JSDoc on |
Sarath1018
marked this pull request as ready for review
July 21, 2026 04:27
This was referenced Jul 21, 2026
Sarath1018
force-pushed
the
feat/identity-users
branch
from
July 21, 2026 04:36
fac9ccc to
fbfb6ef
Compare
Sarath1018
changed the title
Contributor
|
Sarath1018
force-pushed
the
feat/identity-users
branch
from
July 21, 2026 04:42
fbfb6ef to
42cce96
Compare
Sarath1018
force-pushed
the
feat/identity-users-crud
branch
from
July 21, 2026 04:42
c8571c5 to
5e31db9
Compare
Contributor
|
✅ No issues found. Checked for bugs and CLAUDE.md compliance. |
Sarath1018
force-pushed
the
feat/identity-users-crud
branch
from
July 21, 2026 04:48
5e31db9 to
3e38f55
Compare
Sarath1018
force-pushed
the
feat/identity-users
branch
from
July 21, 2026 04:50
42cce96 to
a6e787a
Compare
Contributor
|
✅ No issues found. Checked for bugs and CLAUDE.md compliance. |
Sarath1018
force-pushed
the
feat/identity-users-crud
branch
from
July 21, 2026 05:08
3e38f55 to
b94fcec
Compare
Sarath1018
force-pushed
the
feat/identity-users
branch
from
July 21, 2026 05:08
a6e787a to
cd68ac1
Compare
Contributor
|
✅ No issues found. Checked for bugs and CLAUDE.md compliance. |
Sarath1018
force-pushed
the
feat/identity-users-crud
branch
from
July 21, 2026 06:59
b94fcec to
7288fc2
Compare
Final slice of the Identity user management onboarding (follows the getById and CRUD PRs): - invite(users) POST /api/User/InviteUsers Each invited user receives an invitation email with an accept link. The API reports per-user outcomes — the request can succeed overall while individual invitations fail (e.g. disallowed redirect URL), surfaced via the renamed errorMessage field. Live-API findings encoded: redirectUrl is effectively required and must be a portal acceptInvite URL (the API gateway host is rejected per-user with "Redirect URL is not valid"); failed invitations return an all-zeros GUID. Adds the optional UIPATH_PORTAL_URL integration test config for environments where UIPATH_BASE_URL points at the API gateway host. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sarath1018
force-pushed
the
feat/identity-users
branch
from
July 21, 2026 07:08
cd68ac1 to
f29a250
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 3 of 3 splitting the Identity user management onboarding (stacked on #617, which stacks on #616). Adds the final method:
invite(users)POST /api/User/InviteUsersEach invited user receives an invitation email with an accept link that redirects to
redirectUrl. The API reports per-user outcomes — the request can succeed overall while individual invitations fail, surfaced viasuccess/errorMessageon each entry.Design notes
redirectUrlis effectively required and must be an allowed portalacceptInviteURL — the API gateway host is rejected per-user withRedirect URL is not valididerrorMsgis renamed toerrorMessagein the SDKtransformRequest:groupIds→groupIDs.UIPATH_PORTAL_URLfor environments whereUIPATH_BASE_URLpoints at the API gateway host.Testing
Stack
getByIdupdateById,deleteById,create+ bound entity methodsinviteCloudflare CORS worker: all five endpoints already whitelisted (
api/User/{x}pattern).🤖 Generated with Claude Code